Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail fast if no suitable devices found #34

Merged
merged 5 commits into from
Sep 24, 2024
Merged

fail fast if no suitable devices found #34

merged 5 commits into from
Sep 24, 2024

Conversation

jupe
Copy link
Contributor

@jupe jupe commented Aug 1, 2024 •
edited
Loading

https://github.com/DeviceFarmer/stf/blob/489ba0427e5dd8178c29f4bdd836bfee7d199cce/lib/wire/wire.proto#L365

enum DeviceStatus {
  OFFLINE = 1;
  UNAUTHORIZED = 2;
  ONLINE = 3;
  CONNECTING = 4;
  AUTHORIZING = 5;
}

if device is anything else than online - it's filtered away and fail fast if no any devices left

@coveralls
Copy link

coveralls commented Aug 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10210294477

Details

  • 11 of 12 (91.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 84.222%
Changes Missing Coverage Covered Lines Changed/Added Lines %
stf_appium_client/StfClient.py 11 12 91.67%
Totals Coverage Status
Change from base Build 8417470659: 0.1%
Covered Lines: 379
Relevant Lines: 450
💛 - Coveralls

@jupe jupe requested review from lorjala and juhhov August 2, 2024 11:27
@jupe jupe marked this pull request as ready for review August 2, 2024 11:27
@jupe jupe merged commit 311a796 into main Sep 24, 2024
13 checks passed
@jupe jupe deleted the fail-fast branch September 24, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhhov juhhov juhhov left review comments

@lorjala lorjala Awaiting requested review from lorjala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jupe @coveralls @juhhov